Fin
Some enhancements
  • Envoyé: 19.10.2005, 14:29
    Invité
    rang:
    1
    enregistré depuis:
     décembre 2003
    Status:
    hors ligne
    dernière visite:
    06.03.05
    Messages:
    0
    Hi,

    Thx for doing the avatar. Here is a little contrib to make it even a bit better..

    Purpose:
    To show the avatars in the dropdown before saving.

    I have attached/urled a zip as I don't have the time to post the code and changes here. I did some other slight changes.

    Files affect.
    - pnuser.php
    - pntemplates/pnavatar_user_main.html
    - pnlang/eng/user.php

    Regs

    http://www.sapp...pnavatar.zip

    StormS
    http://www.getagraph.com/ http://www.sapperbase.com
  • Envoyé: 21.11.2005, 21:49
    Invité
    rang:
    1
    enregistré depuis:
     décembre 2003
    Status:
    hors ligne
    dernière visite:
    06.03.05
    Messages:
    0
    Hi,

    here are sone additional changes / bugfixes to pnAvatar 1.0.

    Fix misspelled language symbols:
    Code
    diff -rBwc0 pnavatar\html\modules\pnavatar/pnadmin.php d:pn\modules\pnavatar/pnadmin.php
    *** pnavatar\html\modules\pnavatar/pnadmin.php  Sat Oct  1 20:49:00 2005
    --- d:pn\modules\pnavatar/pnadmin.php   Tue Nov 15 23:04:34 2005
    ***************
    *** 324 ****
    !         pnSessionSetVar('statusmsg', pnVarPrepHTMLDisplay(_UPDATESUCCEDED));
    --- 324 ----
    !         pnSessionSetVar('statusmsg', pnVarPrepHTMLDisplay(_PNAVATAR_UPDATESUCCEDED));
    ***************
    *** 621 ****
    !         pnSessionSetVar('errormsg', pnVarPrepForDisplay(_PNAVATARITEMSPERPAGE));
    --- 621 ----
    !         pnSessionSetVar('errormsg', pnVarPrepForDisplay(_PNAVATAR_ADMIN_ITEMSPERPAGE));
    ***************
    *** 637 ****
    !   pnSessionSetVar('statusmsg', _PNAVATAR_ADMIN_CONFIGSAVE);
    --- 637 ----
    !   pnSessionSetVar('statusmsg', _PNAVATAR_ADMIN_CONFIGSAVED);

    diff -rBwc0 pnavatar\html\modules\pnavatar/pnlang/eng/user.php d:pn\modules\pnavatar/pnlang/eng/user.php
    *** pnavatar\html\modules\pnavatar/pnlang/eng/user.php  Wed Oct 19 15:16:34 2005
    --- d:pn\modules\pnavatar/pnlang/eng/user.php   Mon Nov 21 21:32:10 2005
    ***************
    *** 28 ****
    ! define('_PNAVATAR_UPDATESUCCEDED', 'Avatar successfully updated.');
    --- 28 ----
    ! define('_PNAVATAR_ _UPDATESUCCEDED', 'Avatar successfully updated.');
    Always use EDIT permissions to change user avatar:
    Code
    diff -rBwc0 pnavatar\html\modules\pnavatar/pnuser.php d:pn\modules\pnavatar/pnuser.php
    *** pnavatar\html\modules\pnavatar/pnuser.php   Wed Oct 19 15:05:06 2005
    --- d:pn\modules\pnavatar/pnuser.php    Tue Nov 15 23:34:02 2005
    ***************
    *** 77 ****
    !     $pnRender->assign('canupload', pnSecAuthAction(0, 'pnavatar::', '::', ACCESS_ADD));
    --- 77 ----
    !     $pnRender->assign('canupload', pnSecAuthAction(0, 'pnavatar::', '::', ACCESS_EDIT));
    Hide Link in users profile page if permissions are missing:
    Code
    diff -rBwc0 pnavatar\html\modules\pnavatar/user/links/links.changeavatar.php d:pn\modules\pnavatar/user/links/links.changeavatar.php
    *** pnavatar\html\modules\pnavatar/user/links/links.changeavatar.php    Sat Oct  1 22:27:00 2005
    --- d:pn\modules\pnavatar/user/links/links.changeavatar.php Tue Nov 15 23:53:50 2005
    ***************
    *** 38 ****
    --- 39 ----
    + if (pnSecAuthAction(0, 'pnavatar::', '::', ACCESS_OVERVIEW))
    Fix immeditate preview update after changing selection (the inline funktion showimage is not neccessary):
    Code
    diff -rBwc0 pnavatar\html\modules\pnavatar/pntemplates/pnavatar_user_main.html d:pn\modules\pnavatar/pntemplates/pnavatar_user_main.html
    *** pnavatar\html\modules\pnavatar/pntemplates/pnavatar_user_main.html  Wed Oct 19 15:17:12 2005
    --- d:pn\modules\pnavatar/pntemplates/pnavatar_user_main.html   Mon Nov 21 22:13:46 2005
    ***************
    *** 40 ****
    ! <form id="avatarchange" action="<!--[pnmodurl modname=pnavatar func=change]-->" method="post">
    --- 29 ----
    ! <form name="Register" action="<!--[pnmodurl modname=pnavatar func=change]-->" method="post">


    Regards
    Reiner Maiwald
    reiner.maiwald@freenet.de
  • Envoyé: 07.12.2005, 21:34
       
    vedrine
    rang:
    Site Admin Site Admin
    enregistré depuis:
     décembre 2003
    Status:
    hors ligne
    dernière visite:
    12.05.08
    Messages:
    257
    Thanks a lot for your suggestions. I have implemenrted most of them in pnavatar 1.01 now available in the Downloads section.
    But I want to stick with "add" permissions to allow avatar uploading. This was a carefull decision made during planning pnavatar : allowing your users to upload an avatar, you grant them the right to upload some files on your server. This may be a security risk so I really want webmasters to CHOOSE that, using ADD permission right this can't be the result of a default rule.
  • Envoyé: 10.03.2006, 16:30
    Invité
    rang:
    1
    enregistré depuis:
     décembre 2003
    Status:
    hors ligne
    dernière visite:
    06.03.05
    Messages:
    0
    icon_evil icon_evil icon_frown icon_mad icon_rolleyes icon_wink
Réponse rapide
 
  • Options
Code:
Couleur de la police:  
Taille de la police: